Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block cleanup #19577

Merged
merged 5 commits into from
Nov 19, 2023
Merged

Block cleanup #19577

merged 5 commits into from
Nov 19, 2023

Conversation

dain
Copy link
Member

@dain dain commented Oct 30, 2023 •
edited
Loading

Description

  • Add bulk append methods to BlockBuilder and convert PositionAppenders to them
  • Change VariableWidthBlockBuilder to manage raw byte array internally
  • General cleanup of block code and tests

This PR is part of #14237

Fixes #19396

Release notes

(X) Release notes are required, with the following suggested text:

# SPI
* Add bulk append methods to `BlockBuilder`. ({issue}`19577`)
* Remove `VariableWidthBlockBuilder` `buildEntry` method. ({issue}`19577`)

@dain dain requested a review from electrum October 30, 2023 19:29
@cla-bot cla-bot bot added the cla-signed label Oct 30, 2023
@github-actions github-actions bot added tests:hive iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector mongodb MongoDB connector labels Oct 30, 2023
@dain dain force-pushed the block-cleanup branch 2 times, most recently from d463f69 to b28b185 Compare November 2, 2023 01:17
@dain dain mentioned this pull request Nov 8, 2023
Closed
electrum
electrum approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits through "Convert PositionAppender to use BlockBuilder bulk append methods" look good

core/trino-main/src/main/java/io/trino/type/LikePatternType.java Outdated Show resolved Hide resolved
core/trino-spi/src/main/java/io/trino/spi/block/BlockUtil.java Outdated Show resolved Hide resolved
@dain dain changed the title Final block cleanup Block cleanup Nov 19, 2023
@dain dain merged commit b51e407 into trinodb:master Nov 19, 2023
92 of 93 checks passed
@dain dain deleted the block-cleanup branch November 19, 2023 02:46
@github-actions github-actions bot added this to the 434 milestone Nov 19, 2023
@mosabua mosabua mentioned this pull request Nov 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrum electrum electrum approved these changes

Assignees
No one assigned
Labels
cla-signed delta-lake Delta Lake connector hive Hive connector iceberg Iceberg connector mongodb MongoDB connector
Milestone
434
Development

Successfully merging this pull request may close these issues.

Performance degradation with Hive HCat native implementation
2 participants
@dain @electrum